From 10c0d433f4d2557bd57cf1f2e3b2bbd760ba804c Mon Sep 17 00:00:00 2001 From: Thomas Lange Date: Sun, 24 Oct 2021 17:10:19 +0200 Subject: Declare some BigPipe PHP library methods as void Class BigPipe\BigPipe: * addPhaseDoneJS Class BigPipe\Pagelet: * addHTML * addResource * addJSCode * addDependency * setTagName * setPlaceholderHTML --- include/classes/BigPipe/Item.php | 4 ++-- include/classes/BigPipe/Pagelet.php | 24 ++++++++++++------------ 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/classes/BigPipe/Item.php b/include/classes/BigPipe/Item.php index 6f0e5db..adfe102 100644 --- a/include/classes/BigPipe/Item.php +++ b/include/classes/BigPipe/Item.php @@ -36,7 +36,7 @@ abstract class Item { #=============================================================================== # Attach a PhaseDoneJS callback #=============================================================================== - public function addPhaseDoneJS($phase, $code) { - return $this->phaseDoneJS[$phase][] = $code; + public function addPhaseDoneJS($phase, $code): void { + $this->phaseDoneJS[$phase][] = $code; } } diff --git a/include/classes/BigPipe/Pagelet.php b/include/classes/BigPipe/Pagelet.php index bd50c4b..8c89539 100644 --- a/include/classes/BigPipe/Pagelet.php +++ b/include/classes/BigPipe/Pagelet.php @@ -83,43 +83,43 @@ class Pagelet extends Item { #=============================================================================== # Add HTML or attach more #=============================================================================== - public function addHTML($HTML) { - return $this->HTML .= $HTML; + public function addHTML($HTML): void { + $this->HTML .= $HTML; } #=============================================================================== # Add resource #=============================================================================== - public function addResource(Resource $Resource): Resource { - return $this->resources[$Resource->getType()][] = $Resource; + public function addResource(Resource $Resource): void { + $this->resources[$Resource->getType()][] = $Resource; } #=============================================================================== # Attach a main JS code part #=============================================================================== - public function addJSCode($code) { - return $this->JSCode[] = $code; + public function addJSCode($code): void { + $this->JSCode[] = $code; } #=============================================================================== # Attach a display dependency #=============================================================================== - public function addDependency(Pagelet $Pagelet) { - return $this->dependencies[] = $Pagelet->getID(); + public function addDependency(Pagelet $Pagelet): void { + $this->dependencies[] = $Pagelet->getID(); } #=============================================================================== # Set custom placeholder tag name #=============================================================================== - public function setTagName($tagName) { - return $this->tagName = $tagName; + public function setTagName($tagName): void { + $this->tagName = $tagName; } #=============================================================================== # Set custom placeholder HTML #=============================================================================== - public function setPlaceholderHTML($HTML) { - return $this->tagHTML = $HTML; + public function setPlaceholderHTML($HTML): void { + $this->tagHTML = $HTML; } #=============================================================================== -- cgit v1.2.3