Use method "buildByAttribute" to create Item instances for item listing

This commit significantly reduces the number of database queries required to display a list of pages, posts or users. This could be achieved by using "SELECT * FROM […]" in combination with the new implemented factory method "buildByAttribute".

Previously, the first database query returned an array of unique item IDs that were then passed to the factory method "build" within the "foreach" loop which caused the application to make an additional database query like "SELECT * FROM […] WHERE id = {current_id}" for every single item ID to get it's payload data. Since this commit, this additional query for every item is not necessary anymore.

5 files changed, 23 insertions, 25 deletions

diff --git a/core/include/feed/main.php b/core/include/feed/main.php
index b8e03dc..84f3edb 100644
--- a/core/include/feed/main.php
+++ b/core/include/feed/main.php
@@ -18,12 +18,12 @@ try {
 		$POST['FEED_SORT'] = Application::get('POST.FEED_SORT');
 		$POST['FEED_SIZE'] = Application::get('POST.FEED_SIZE');
 
-		$execSQL = "SELECT id FROM %s ORDER BY {$POST['FEED_SORT']} LIMIT {$POST['FEED_SIZE']}";
-		$postIDs = $Database->query(sprintf($execSQL, Post\Attribute::TABLE))->fetchAll($Database::FETCH_COLUMN);
+		$execSQL = "SELECT * FROM %s ORDER BY {$POST['FEED_SORT']} LIMIT {$POST['FEED_SIZE']}";
+		$Statement = $Database->query(sprintf($execSQL, Post\Attribute::TABLE));
 
-		foreach($postIDs as $postID) {
+		while($Attribute = $Statement->fetchObject('Post\Attribute')) {
 			try {
-				$Post = Post\Factory::build($postID);
+				$Post = Post\Factory::buildByAttribute($Attribute);
 				$User = User\Factory::build($Post->attr('user'));
 
 				$ItemTemplate = Template\Factory::build('feed/item_post');
@@ -42,12 +42,12 @@ try {
 		$PAGE['FEED_SORT'] = Application::get('PAGE.FEED_SORT');
 		$PAGE['FEED_SIZE'] = Application::get('PAGE.FEED_SIZE');
 
-		$execSQL = "SELECT id FROM %s ORDER BY {$PAGE['FEED_SORT']} LIMIT {$PAGE['FEED_SIZE']}";
-		$pageIDs = $Database->query(sprintf($execSQL, Page\Attribute::TABLE))->fetchAll($Database::FETCH_COLUMN);
+		$execSQL = "SELECT * FROM %s ORDER BY {$PAGE['FEED_SORT']} LIMIT {$PAGE['FEED_SIZE']}";
+		$Statement = $Database->query(sprintf($execSQL, Page\Attribute::TABLE));
 
-		foreach($pageIDs as $pageID) {
+		while($Attribute = $Statement->fetchObject('Page\Attribute')) {
 			try {
-				$Page = Page\Factory::build($pageID);
+				$Page = Page\Factory::buildByAttribute($Attribute);
 				$User = User\Factory::build($Page->attr('user'));
 
 				$ItemTemplate = Template\Factory::build('feed/item_page');
diff --git a/core/include/home.php b/core/include/home.php
index ce91558..2fe81a2 100644
--- a/core/include/home.php
+++ b/core/include/home.php
@@ -9,14 +9,12 @@ $Language = Application::getLanguage();
 # TRY: Template\Exception
 #===============================================================================
 try {
-	$execSQL = 'SELECT id FROM %s ORDER BY '.Application::get('POST.LIST_SORT').' LIMIT '.Application::get('POST.LIST_SIZE');
+	$execSQL = 'SELECT * FROM %s ORDER BY '.Application::get('POST.LIST_SORT').' LIMIT '.Application::get('POST.LIST_SIZE');
 	$Statement = $Database->query(sprintf($execSQL, Post\Attribute::TABLE));
 
-	$postIDs = $Statement->fetchAll($Database::FETCH_COLUMN);
-
-	foreach($postIDs as $postID) {
+	while($Attribute = $Statement->fetchObject('Post\Attribute')) {
 		try {
-			$Post = Post\Factory::build($postID);
+			$Post = Post\Factory::buildByAttribute($Attribute);
 			$User = User\Factory::build($Post->attr('user'));
 
 			$ItemTemplate = generatePostItemTemplate($Post, $User);
diff --git a/core/include/page/list.php b/core/include/page/list.php
index 022478e..656d01a 100644
--- a/core/include/page/list.php
+++ b/core/include/page/list.php
@@ -34,12 +34,12 @@ if(Application::get('PAGE.SINGLE_REDIRECT') === TRUE AND $count === '1') {
 # TRY: Template\Exception
 #===============================================================================
 try {
-	$execSQL = "SELECT id FROM %s ORDER BY {$site_sort} LIMIT ".(($currentSite-1) * $site_size).", {$site_size}";
-	$pageIDs = $Database->query(sprintf($execSQL, Page\Attribute::TABLE))->fetchAll($Database::FETCH_COLUMN);
+	$execSQL = "SELECT * FROM %s ORDER BY {$site_sort} LIMIT ".(($currentSite-1) * $site_size).", {$site_size}";
+	$Statement = $Database->query(sprintf($execSQL, Page\Attribute::TABLE));
 
-	foreach($pageIDs as $pageID) {
+	while($Attribute = $Statement->fetchObject('Page\Attribute')) {
 		try {
-			$Page = Page\Factory::build($pageID);
+			$Page = Page\Factory::buildByAttribute($Attribute);
 			$User = User\Factory::build($Page->attr('user'));
 
 			$ItemTemplate = generatePageItemTemplate($Page, $User);
diff --git a/core/include/post/list.php b/core/include/post/list.php
index 3ba2dba..6ade592 100644
--- a/core/include/post/list.php
+++ b/core/include/post/list.php
@@ -34,12 +34,12 @@ if(Application::get('POST.SINGLE_REDIRECT') === TRUE AND $count === '1') {
 # TRY: Template\Exception
 #===============================================================================
 try {
-	$execSQL = "SELECT id FROM %s ORDER BY {$site_sort} LIMIT ".(($currentSite-1) * $site_size).", {$site_size}";
-	$postIDs = $Database->query(sprintf($execSQL, Post\Attribute::TABLE))->fetchAll($Database::FETCH_COLUMN);
+	$execSQL = "SELECT * FROM %s ORDER BY {$site_sort} LIMIT ".(($currentSite-1) * $site_size).", {$site_size}";
+	$Statement = $Database->query(sprintf($execSQL, Post\Attribute::TABLE));
 
-	foreach($postIDs as $postID) {
+	while($Attribute = $Statement->fetchObject('Post\Attribute')) {
 		try {
-			$Post = Post\Factory::build($postID);
+			$Post = Post\Factory::buildByAttribute($Attribute);
 			$User = User\Factory::build($Post->attr('user'));
 
 			$ItemTemplate = generatePostItemTemplate($Post, $User);
diff --git a/core/include/user/list.php b/core/include/user/list.php
index 4ce9fc8..adc28ec 100644
--- a/core/include/user/list.php
+++ b/core/include/user/list.php
@@ -34,12 +34,12 @@ if(Application::get('USER.SINGLE_REDIRECT') === TRUE AND $count === '1') {
 # TRY: Template\Exception
 #===============================================================================
 try {
-	$execSQL = "SELECT id FROM %s ORDER BY {$site_sort} LIMIT ".(($currentSite-1) * $site_size).", {$site_size}";
-	$userIDs = $Database->query(sprintf($execSQL, User\Attribute::TABLE))->fetchAll($Database::FETCH_COLUMN);
+	$execSQL = "SELECT * FROM %s ORDER BY {$site_sort} LIMIT ".(($currentSite-1) * $site_size).", {$site_size}";
+	$Statement = $Database->query(sprintf($execSQL, User\Attribute::TABLE));
 
-	foreach($userIDs as $userID) {
+	while($Attribute = $Statement->fetchObject('User\Attribute')) {
 		try {
-			$User = User\Factory::build($userID);
+			$User = User\Factory::buildByAttribute($Attribute);
 			$ItemTemplate = generateUserItemTemplate($User);
 
 			$users[] = $ItemTemplate;