From a0722c6d149b253a320976a64aad6e57ab1cccd7 Mon Sep 17 00:00:00 2001
From: Thomas Lange <code@nerdmind.de>
Date: Thu, 5 Aug 2021 18:19:19 +0200
Subject: Don't check return value of insert/delete methods

Don't check the return value of the Repository's "insert" and "delete"
methods in the administration controllers for creating and modifying
entities since a PDOException is thrown if an error occurs.
---
 admin/category/delete.php | 5 ++---
 admin/category/insert.php | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

(limited to 'admin/category')

diff --git a/admin/category/delete.php b/admin/category/delete.php
index d7b3001..c443c4a 100644
--- a/admin/category/delete.php
+++ b/admin/category/delete.php
@@ -28,9 +28,8 @@ if(!$Category = $CategoryRepository->find(HTTP::GET('id'))) {
 if(HTTP::issetPOST('delete')) {
 	if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
 		try {
-			if($CategoryRepository->delete($Category)) {
-				HTTP::redirect(Application::getAdminURL('category/'));
-			}
+			$CategoryRepository->delete($Category);
+			HTTP::redirect(Application::getAdminURL('category/'));
 		} catch(PDOException $Exception) {
 			$messages[] = $Exception->getMessage();
 		}
diff --git a/admin/category/insert.php b/admin/category/insert.php
index 773bb29..c63ad06 100644
--- a/admin/category/insert.php
+++ b/admin/category/insert.php
@@ -34,9 +34,8 @@ if(HTTP::issetPOST('insert')) {
 
 	if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
 		try {
-			if($CategoryRepository->insert($Category)) {
-				HTTP::redirect(Application::getAdminURL('category/'));
-			}
+			$CategoryRepository->insert($Category);
+			HTTP::redirect(Application::getAdminURL('category/'));
 		} catch(PDOException $Exception) {
 			$messages[] = $Exception->getMessage();
 		}
-- 
cgit v1.2.3