From 78fcc20190121d487a2e6cf1fca53b66df67dc3a Mon Sep 17 00:00:00 2001
From: Thomas Lange <code@nerdmind.de>
Date: Mon, 14 Jun 2021 20:03:19 +0200
Subject: Remove more redundant try/catch blocks

Remove all try/catch blocks where the exception handling did not differ
from the exception handler already defined by "set_exception_handler".
---
 admin/page/update.php | 59 ++++++++++++++++++++++-----------------------------
 1 file changed, 25 insertions(+), 34 deletions(-)

(limited to 'admin/page/update.php')

diff --git a/admin/page/update.php b/admin/page/update.php
index a7c9cd0..ba34a86 100644
--- a/admin/page/update.php
+++ b/admin/page/update.php
@@ -39,45 +39,36 @@ try {
 		}
 	}
 
-	#===============================================================================
-	# TRY: Template\Exception
-	#===============================================================================
-	try {
-		$userIDs = $Database->query(sprintf('SELECT id FROM %s ORDER BY fullname ASC', User\Attribute::TABLE));
-
-		foreach($userIDs->fetchAll($Database::FETCH_COLUMN) as $userID) {
-			$User = User\Factory::build($userID);
-			$userAttributes[] = [
-				'ID' => $User->attr('id'),
-				'FULLNAME' => $User->attr('fullname'),
-				'USERNAME' => $User->attr('username'),
-			];
-		}
-
-		$FormTemplate = Template\Factory::build('page/form');
-		$FormTemplate->set('FORM', [
-			'TYPE' => 'UPDATE',
-			'INFO' => $messages ?? [],
-			'DATA' => array_change_key_case($Attribute->getAll(), CASE_UPPER),
-			'USER_LIST' => $userAttributes ??  [],
-			'TOKEN' => Application::getSecurityToken()
-		]);
+	$userIDs = $Database->query(sprintf('SELECT id FROM %s ORDER BY fullname ASC', User\Attribute::TABLE));
 
-		$PageUpdateTemplate = Template\Factory::build('page/update');
-		$PageUpdateTemplate->set('HTML', $FormTemplate);
-
-		$MainTemplate = Template\Factory::build('main');
-		$MainTemplate->set('NAME', $Language->text('title_page_update'));
-		$MainTemplate->set('HTML', $PageUpdateTemplate);
-		echo $MainTemplate;
+	foreach($userIDs->fetchAll($Database::FETCH_COLUMN) as $userID) {
+		$User = User\Factory::build($userID);
+		$userAttributes[] = [
+			'ID' => $User->attr('id'),
+			'FULLNAME' => $User->attr('fullname'),
+			'USERNAME' => $User->attr('username'),
+		];
 	}
 
 	#===============================================================================
-	# CATCH: Template\Exception
+	# Build document
 	#===============================================================================
-	catch(Template\Exception $Exception) {
-		Application::exit($Exception->getMessage());
-	}
+	$FormTemplate = Template\Factory::build('page/form');
+	$FormTemplate->set('FORM', [
+		'TYPE' => 'UPDATE',
+		'INFO' => $messages ?? [],
+		'DATA' => array_change_key_case($Attribute->getAll(), CASE_UPPER),
+		'USER_LIST' => $userAttributes ??  [],
+		'TOKEN' => Application::getSecurityToken()
+	]);
+
+	$PageUpdateTemplate = Template\Factory::build('page/update');
+	$PageUpdateTemplate->set('HTML', $FormTemplate);
+
+	$MainTemplate = Template\Factory::build('main');
+	$MainTemplate->set('NAME', $Language->text('title_page_update'));
+	$MainTemplate->set('HTML', $PageUpdateTemplate);
+	echo $MainTemplate;
 }
 
 #===============================================================================
-- 
cgit v1.2.3