aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Lange <code@nerdmind.de>2021-08-05 18:19:19 +0200
committerThomas Lange <code@nerdmind.de>2021-08-05 18:27:08 +0200
commita0722c6d149b253a320976a64aad6e57ab1cccd7 (patch)
tree12529b8ffb17043e956b2afe4cb28359f28eec5b
parentde51f59ef9a50bce0ef63a883c590d1feeadca5d (diff)
downloadblog-a0722c6d149b253a320976a64aad6e57ab1cccd7.tar.gz
blog-a0722c6d149b253a320976a64aad6e57ab1cccd7.tar.xz
blog-a0722c6d149b253a320976a64aad6e57ab1cccd7.zip
Don't check return value of insert/delete methods
Don't check the return value of the Repository's "insert" and "delete" methods in the administration controllers for creating and modifying entities since a PDOException is thrown if an error occurs.
-rw-r--r--admin/category/delete.php5
-rw-r--r--admin/category/insert.php5
-rw-r--r--admin/page/delete.php5
-rw-r--r--admin/page/insert.php5
-rw-r--r--admin/post/delete.php5
-rw-r--r--admin/post/insert.php5
-rw-r--r--admin/user/delete.php5
-rw-r--r--admin/user/insert.php5
8 files changed, 16 insertions, 24 deletions
diff --git a/admin/category/delete.php b/admin/category/delete.php
index d7b3001..c443c4a 100644
--- a/admin/category/delete.php
+++ b/admin/category/delete.php
@@ -28,9 +28,8 @@ if(!$Category = $CategoryRepository->find(HTTP::GET('id'))) {
if(HTTP::issetPOST('delete')) {
if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
try {
- if($CategoryRepository->delete($Category)) {
- HTTP::redirect(Application::getAdminURL('category/'));
- }
+ $CategoryRepository->delete($Category);
+ HTTP::redirect(Application::getAdminURL('category/'));
} catch(PDOException $Exception) {
$messages[] = $Exception->getMessage();
}
diff --git a/admin/category/insert.php b/admin/category/insert.php
index 773bb29..c63ad06 100644
--- a/admin/category/insert.php
+++ b/admin/category/insert.php
@@ -34,9 +34,8 @@ if(HTTP::issetPOST('insert')) {
if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
try {
- if($CategoryRepository->insert($Category)) {
- HTTP::redirect(Application::getAdminURL('category/'));
- }
+ $CategoryRepository->insert($Category);
+ HTTP::redirect(Application::getAdminURL('category/'));
} catch(PDOException $Exception) {
$messages[] = $Exception->getMessage();
}
diff --git a/admin/page/delete.php b/admin/page/delete.php
index 035dbee..8542187 100644
--- a/admin/page/delete.php
+++ b/admin/page/delete.php
@@ -28,9 +28,8 @@ if(!$Page = $PageRepository->find(HTTP::GET('id'))) {
if(HTTP::issetPOST('delete')) {
if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
try {
- if($PageRepository->delete($Page)) {
- HTTP::redirect(Application::getAdminURL('page/'));
- }
+ $PageRepository->delete($Page);
+ HTTP::redirect(Application::getAdminURL('page/'));
} catch(PDOException $Exception) {
$messages[] = $Exception->getMessage();
}
diff --git a/admin/page/insert.php b/admin/page/insert.php
index c1d9e5d..915fee5 100644
--- a/admin/page/insert.php
+++ b/admin/page/insert.php
@@ -35,9 +35,8 @@ if(HTTP::issetPOST('insert')) {
if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
try {
- if($PageRepository->insert($Page)) {
- HTTP::redirect(Application::getAdminURL('page/'));
- }
+ $PageRepository->insert($Page);
+ HTTP::redirect(Application::getAdminURL('page/'));
} catch(PDOException $Exception) {
$messages[] = $Exception->getMessage();
}
diff --git a/admin/post/delete.php b/admin/post/delete.php
index 3fb4c84..501cae4 100644
--- a/admin/post/delete.php
+++ b/admin/post/delete.php
@@ -28,9 +28,8 @@ if(!$Post = $PostRepository->find(HTTP::GET('id'))) {
if(HTTP::issetPOST('delete')) {
if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
try {
- if($PostRepository->delete($Post)) {
- HTTP::redirect(Application::getAdminURL('post/'));
- }
+ $PostRepository->delete($Post);
+ HTTP::redirect(Application::getAdminURL('post/'));
} catch(PDOException $Exception) {
$messages[] = $Exception->getMessage();
}
diff --git a/admin/post/insert.php b/admin/post/insert.php
index 1a8cac7..1b04ecc 100644
--- a/admin/post/insert.php
+++ b/admin/post/insert.php
@@ -37,9 +37,8 @@ if(HTTP::issetPOST('insert')) {
if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
try {
- if($PostRepository->insert($Post)) {
- HTTP::redirect(Application::getAdminURL('post/'));
- }
+ $PostRepository->insert($Post);
+ HTTP::redirect(Application::getAdminURL('post/'));
} catch(PDOException $Exception) {
$messages[] = $Exception->getMessage();
}
diff --git a/admin/user/delete.php b/admin/user/delete.php
index 31389a2..1a7628c 100644
--- a/admin/user/delete.php
+++ b/admin/user/delete.php
@@ -28,9 +28,8 @@ if(!$User = $UserRepository->find(HTTP::GET('id'))) {
if(HTTP::issetPOST('delete')) {
if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
try {
- if($UserRepository->delete($User)) {
- HTTP::redirect(Application::getAdminURL('user/'));
- }
+ $UserRepository->delete($User);
+ HTTP::redirect(Application::getAdminURL('user/'));
} catch(PDOException $Exception) {
$messages[] = $Exception->getMessage();
}
diff --git a/admin/user/insert.php b/admin/user/insert.php
index 48cbf65..c337e21 100644
--- a/admin/user/insert.php
+++ b/admin/user/insert.php
@@ -36,9 +36,8 @@ if(HTTP::issetPOST('insert')) {
if(HTTP::issetPOST(['token' => Application::getSecurityToken()])) {
try {
- if($UserRepository->insert($User)) {
- HTTP::redirect(Application::getAdminURL('user/'));
- }
+ $UserRepository->insert($User);
+ HTTP::redirect(Application::getAdminURL('user/'));
} catch(PDOException $Exception) {
$messages[] = $Exception->getMessage();
}